Skip to content

update stellar-wallets-kit to the latest (v2.5.0)#2124

Merged
jeesunikim merged 5 commits into
mainfrom
update-stellar-wallets-kit
Jul 6, 2026
Merged

update stellar-wallets-kit to the latest (v2.5.0)#2124
jeesunikim merged 5 commits into
mainfrom
update-stellar-wallets-kit

Conversation

@jeesunikim

@jeesunikim jeesunikim commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Release note: v2.4.0 remove the library @stellar/stellar-base and install @stellar/stellar-sdk (the base version has been deprecated by Stellar)

Copilot AI review requested due to automatic review settings June 24, 2026 17:08
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jun 24, 2026
Copilot AI reviewed Jun 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s wallet integration dependency to @creit.tech/stellar-wallets-kit@2.4.0, reflecting upstream changes (including migration away from deprecated @stellar/stellar-base in favor of @stellar/stellar-sdk). It also includes a large regeneration/update of the auto-generated Soroban network limits constants.

Changes:

  • Bump @creit.tech/stellar-wallets-kit from ^2.2.0 to ^2.4.0.
  • Update pnpm-lock.yaml to reflect the new dependency graph (including new transitive dependencies).
  • Update the auto-generated src/constants/networkLimits.ts contents (limits values and formatting).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/constants/networkLimits.ts Updates auto-generated network limits/constants (large diff; impacts runtime limits used by the app).
package.json Bumps @creit.tech/stellar-wallets-kit dependency to ^2.4.0.
pnpm-lock.yaml Locks updated dependency graph for the stellar-wallets-kit@2.4.0 upgrade and related transitive updates.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/constants/networkLimits.ts
Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
@stellar-jenkins-ci

stellar-jenkins-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

Preview is available here:
http://laboratory-pr2124.previews.kube001.services.stellar-ops.com/

@socket-security

socket-security Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​creit.tech/​stellar-wallets-kit@​2.5.0841009894100

View full report

@socket-security

socket-security Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm @trezor/connect-plugin-stellar under LicenseRef-T-RSL

License: LicenseRef-T-RSL - The applicable license policy does not permit this license (5) (package/LICENSE.md)

From: pnpm-lock.yaml → npm/@creit.tech/stellar-wallets-kit@2.5.0 → npm/@trezor/connect-plugin-stellar@10.0.0-alpha.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@trezor/connect-plugin-stellar@10.0.0-alpha.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@jeesunikim jeesunikim requested a review from quietbits June 24, 2026 17:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@jeesunikim jeesunikim changed the title update stellar-wallets-kit to the latest (v2.4.0) update stellar-wallets-kit to the latest (v2.5.0) Jul 6, 2026
@stellar-jenkins-ci

stellar-jenkins-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

Preview is available here:
http://laboratory-pr2124.previews.kube001.services.stellar-ops.com/

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@stellar-jenkins-ci

stellar-jenkins-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@stellar-jenkins-ci

stellar-jenkins-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins-ci

stellar-jenkins-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown

Preview is available here:
http://laboratory-pr2124.previews.kube001.services.stellar-ops.com/

@jeesunikim jeesunikim merged commit 171916f into main Jul 6, 2026
7 checks passed
@jeesunikim jeesunikim deleted the update-stellar-wallets-kit branch July 6, 2026 21:32
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@quietbits quietbits quietbits approved these changes

Assignees

No one assigned

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeesunikim @quietbits